feat(module)!: use moduleDependencies to manipulate options
#4927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@danielroe Don't we need to update to |
Member
Author
|
oh, quite right. I'll update this PR once 4.1.2 is out. |
benjamincanac
changed the title
moduleDependencies to manipulate options
benjamincanac
force-pushed
the
v4
branch
2 times, most recently
from
3f0c24a to
c9ba808
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
commit: |
benjamincanac
changed the title
moduleDependencies to manipulate optionsmoduleDependencies to manipulate options
danielroe
commented
Nov 4, 2025
| } | ||
|
|
||
| if ((hasNuxtModule('@nuxt/content') || options.content)) { | ||
| if (options.content || hasNuxtModule('@nuxt/content')) { |
Member
Author
There was a problem hiding this comment.
I've swapped these in every instance as checking options.content is always going to be more performant than calling hasNuxtModule
danielroe
commented
Nov 4, 2025
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Contributor
|
Hey @danielroe Will this resolve the strict order issue for nuxt/content & nuxt/ui? Do you want me to create issue for tracking auto creating main.css and including it in nuxt.config when creating new nuxt project and selecting Nuxt UI as module? cc: @benjamincanac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
this uses the new module dependencies feature in https://github.com/nuxt/nuxt/releases/tag/v4.1.0 to specify options for other modules (and require them).
Schema + kit are pinned because this repo is using shamefully-hoist, and the wrong version of each of these might be hoisted.(We ultimately need to resolve that issue, but it's for another time.)I'm opening this as a draft because it's very possible that something might break.📝 Checklist